On 06/21/2018 01:01 AM, John Ferlan wrote: > v2: https://www.redhat.com/archives/libvir-list/2018-May/msg01268.html > > Try #3 - this time since Peter removed support for qcow encrypted > volumes for domains, I'm taking the same approach for storage. > > This is totally different from the previous approach which tried to > actually create a qcow2 encrypted volume. This time slowly extricate > the qcow2 encryption support from the storage driver - at least anything > that can have a result via qemu-img. > > Additionally, added some more luks tests and added the capability > to create a luks encrypted volume from a raw image using the two > step process that was part of v2. > > John Ferlan (10): > storage: Don't allow encryption secretPath to be NULL > tests: Add luks creation examples to storagevolxml2argvtest > storage: Rename encryption info variable for clarity > tests: Remove qcow2 encryption from storagevol tests > storage: Disallow create/resize of qcow2 encrypted images > storage: Clean up storageBackendCreateQemuImgCheckEncryption > storage: Clean up storageBackendCreateQemuImgOpts > storage: Remove storageBackendGenerateSecretData > storage: Add support for using inputvol for encryption > docs: Add news article for volume encryption modifications > > docs/formatsecret.html.in | 22 +- > docs/formatstorageencryption.html.in | 29 +- > docs/news.xml | 25 ++ > src/storage/storage_util.c | 303 +++++++-------------- > src/storage/storage_util.h | 10 +- > src/util/virqemu.c | 26 +- > tests/storagevolxml2argvdata/luks-cipher.argv | 5 + > tests/storagevolxml2argvdata/luks-convert.argv | 9 + > tests/storagevolxml2argvdata/luks.argv | 4 + > tests/storagevolxml2argvdata/qcow2-1.1.argv | 2 +- > tests/storagevolxml2argvdata/qcow2-compat.argv | 2 +- > .../qcow2-from-logical-compat.argv | 2 +- > tests/storagevolxml2argvdata/qcow2-lazy.argv | 2 +- > .../qcow2-nobacking-convert-prealloc-compat.argv | 2 +- > .../qcow2-nobacking-prealloc-compat.argv | 2 +- > .../qcow2-nocapacity-convert-prealloc.argv | 2 +- > tests/storagevolxml2argvdata/qcow2-nocapacity.argv | 2 +- > .../storagevolxml2argvdata/qcow2-nocow-compat.argv | 2 +- > tests/storagevolxml2argvtest.c | 76 +++++- > tests/storagevolxml2xmlin/vol-luks-convert.xml | 21 ++ > tests/storagevolxml2xmlin/vol-qcow2-0.10-lazy.xml | 3 - > tests/storagevolxml2xmlin/vol-qcow2-1.1.xml | 3 - > tests/storagevolxml2xmlin/vol-qcow2-encryption.xml | 31 +++ > tests/storagevolxml2xmlin/vol-qcow2-lazy.xml | 3 - > tests/storagevolxml2xmlin/vol-qcow2-nobacking.xml | 3 - > .../vol-qcow2-nocapacity-backing.xml | 3 - > tests/storagevolxml2xmlin/vol-qcow2-nocapacity.xml | 3 - > tests/storagevolxml2xmlin/vol-qcow2-nocow.xml | 3 - > tests/storagevolxml2xmlin/vol-qcow2.xml | 3 - > tests/storagevolxml2xmlout/vol-qcow2-0.10-lazy.xml | 3 - > tests/storagevolxml2xmlout/vol-qcow2-1.1.xml | 3 - > .../storagevolxml2xmlout/vol-qcow2-encryption.xml | 31 +++ > tests/storagevolxml2xmlout/vol-qcow2-lazy.xml | 3 - > tests/storagevolxml2xmlout/vol-qcow2-nobacking.xml | 3 - > .../storagevolxml2xmlout/vol-qcow2-nocapacity.xml | 3 - > tests/storagevolxml2xmlout/vol-qcow2-nocow.xml | 3 - > tests/storagevolxml2xmlout/vol-qcow2.xml | 3 - > tests/storagevolxml2xmltest.c | 1 + > 38 files changed, 344 insertions(+), 312 deletions(-) > create mode 100644 tests/storagevolxml2argvdata/luks-cipher.argv > create mode 100644 tests/storagevolxml2argvdata/luks-convert.argv > create mode 100644 tests/storagevolxml2argvdata/luks.argv > create mode 100644 tests/storagevolxml2xmlin/vol-luks-convert.xml > create mode 100644 tests/storagevolxml2xmlin/vol-qcow2-encryption.xml > create mode 100644 tests/storagevolxml2xmlout/vol-qcow2-encryption.xml > ACK series. Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
