Subject: [PATCH] qemu: monitor: Fix memory leak in qemuMonitorJSONNBDServerStart() Exiting early through the return path did result in 'port_str' being leaked. Signed-off-by: Jie Wang <wangjie88.huawei.com> --- src/qemu/qemu_monitor_json.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index aa89ea7056..3e90279b71 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -6540,7 +6540,7 @@ qemuMonitorJSONNBDServerStart(qemuMonitorPtr mon, return ret; if (!(addr = qemuMonitorJSONBuildInetSocketAddress(host, port_str))) - return ret; + goto cleanup; if (!(cmd = qemuMonitorJSONMakeCommand("nbd-server-start", "a:addr", &addr, -- 2.15.0.windows.1 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list