On Thu, Jun 21, 2018 at 02:50:49PM +0100, Daniel P. Berrangé wrote:
> On Thu, Jun 21, 2018 at 03:37:49PM +0200, Andrea Bolognani wrote:
> > On Thu, 2018-06-21 at 14:21 +0200, Pavel Hrdina wrote:
> > [...]
> > > @@ -31,8 +31,7 @@
> > > triggers:
> > > - reverse:
> > > jobs: '{obj:parent_jobs}'
> > > - - pollscm:
> > > - cron: "H/20 * * * *"
> > > + - github
> >
> > As noted in the review for the previous patch
> >
> > libosinfo: https://gitlab.com/libosinfo/libosinfo.git
> > osinfo-db-tools: https://gitlab.com/libosinfo/osinfo-db-tools.git
> > osinfo-db: https://gitlab.com/libosinfo/osinfo-db.git
> > virt-viewer: https://pagure.io/virt-viewer.git
> >
> > are not hosted on GitHub, so the above won't work for them.
> >
> > There's probably a way to make something like this work for GitLab
> > too, but I'm not very confident about Pagure.
> >
> > Perhaps we can convince the projects listed above to set up
> > mirroring to GitHub...
>
> I think its better if we just leave the jenkins config using pollscm
> as it does today, but simply point it at an appropriate repo for
> each project, instead of using github webhooks or the local cached
> git.
>
> This kind of need to mirror/move everything to github just to use
> their unique features, is exactly the kind of embrace & extend that
> makes github undesirable. Better to stick to core git functionality.
Yes, I agree with that.
I'll work on the changes required for the first patch.
Thanks
Pavel
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
