On Fri, Jun 15, 2018 at 07:03:41PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou <kkoukiou@xxxxxxxxxx> > --- > > Some note about the test: > > 1: The previous test should not use the node_device_create fixture introduced here > for the following reason: > The fixture is creating the device in the setup of the test since the > device creation is not supposed to be tested in other tests apart from > the CreateXML test. Only that test should not have the creation in the > setup, but in the actual test `call` part. > > 2: I didn't create the get_test_node_device function as other entities have > because ListNodeDevices method is not supported by the test driver > > data/org.libvirt.NodeDevice.xml | 4 ++++ > src/nodedev.c | 42 +++++++++++++++++++++++++++++++++++++++++ > tests/Makefile.am | 1 + > tests/libvirttest.py | 10 ++++++++++ > tests/test_nodedev.py | 31 ++++++++++++++++++++++++++++++ > 5 files changed, 88 insertions(+) > create mode 100755 tests/test_nodedev.py Reviewed-by: Pavel Hrdina <phrdina@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
