On 06/12/2018 11:04 AM, Michal Privoznik wrote: > When updating device it's worth parsing live info too as users > might want to update it as well. > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > --- > src/qemu/qemu_driver.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > So this follows what DetachLiveAndConfig has done with altering parse_flags to add the inactive mainly because it "makes sense" to attempt to match whatever "live/active" device may exist to the fullest possible extent including fields that wouldn't normally be parsed for an inactive guest. Took a bit to come to that conclusion ;-) because the commit message above didn't give me that! Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx> John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list