Re: [PATCH] libvirtd: Add service dependency on systemd-logind

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2018-06-12 at 09:47 -0400, Cole Robinson wrote:
> At daemon startup we query logind for host PM support status. Without
> a service dependency host startup can trigger libvirtd errors like:
> 
> error : virNodeSuspendSupportsTarget:336 : internal error: Cannot probe for
> supported suspend types
> warning : virQEMUCapsInit:949 : Failed to get host power management
> capabilities
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1588288

Please leave a blank line here.

Some people would argue the Resolves: prefix is pointless and/or
harmful, so consider dropping it. Or, you know, don't :)

> Signed-off-by: Cole Robinson <crobinso@xxxxxxxxxx>
> ---
>  src/remote/libvirtd.service.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/remote/libvirtd.service.in b/src/remote/libvirtd.service.in
> index 769702ea75..7f689e08a8 100644
> --- a/src/remote/libvirtd.service.in
> +++ b/src/remote/libvirtd.service.in
> @@ -15,6 +15,7 @@ After=iscsid.service
>  After=apparmor.service
>  After=local-fs.target
>  After=remote-fs.target
> +After=systemd-logind.service
>  After=systemd-machined.service
>  Documentation=man:libvirtd(8)
>  Documentation=https://libvirt.org

Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux