On Thu, 2009-09-17 at 16:02 +0100, Mark McLoughlin wrote: > When we hot-unplug the last device, we're currently double-freeing > the device definition. > > Reported by Michal Nowak here: > > https://bugzilla.redhat.com/523953 Sorry, I got bugs mixed up, it was Martin Banas who reported this. Cheers, Mark. > > * src/qemu_driver.c: fix double free > --- > src/qemu_driver.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/qemu_driver.c b/src/qemu_driver.c > index a65334f..de31581 100644 > --- a/src/qemu_driver.c > +++ b/src/qemu_driver.c > @@ -5998,7 +5998,7 @@ try_command: > /* ignore, harmless */ > } > } else { > - VIR_FREE(vm->def->disks[0]); > + VIR_FREE(vm->def->disks); > vm->def->ndisks = 0; > } > virDomainDiskDefFree(detach); > @@ -6100,7 +6100,7 @@ qemudDomainDetachNetDevice(virConnectPtr conn, > /* ignore, harmless */ > } > } else { > - VIR_FREE(vm->def->nets[0]); > + VIR_FREE(vm->def->nets); > vm->def->nnets = 0; > } > virDomainNetDefFree(detach); -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list