On Mon, Jun 11, 2018 at 3:34 PM, Ján Tomko <jtomko@xxxxxxxxxx> wrote: > On Mon, May 28, 2018 at 12:28:19AM +0200, Fabiano Fidêncio wrote: >> >> This patchset finishes the conversion to virConfGetValue* functions, >> started by Daniel Berrange a few months ago. >> >> Please, mind that although we could make virConfGetValue* functions more >> generic in order to support numbers and booleans as strings, that >> doesn't seem the safest path to take. The side-effect of this is that we >> will have to live with some specific code doing that as part of vmx and >> xen_common. >> >> Once this patchset gets merged, >> >> https://wiki.libvirt.org/page/BiteSizedTasks#Finish_conversion_to_virConfGetValue.2A_functions >> can be removed. >> >> - Changes since v1: >> All the "values" from virConfGetValueString() are freed >> >> - Changes since v2: >> All comments from Ján Tomko have been addressed; >> A few leaks were (possibly) found and they're addressed in the last >> patch of the series; >> >> Fabiano Fidêncio (7): >> xen_xm: Split the per-disk logic from xenParseXMDisk() >> xen_vm: convert to typesafe virConf accessors >> vmx: convert to typesafe virConf accessors >> xen_common: Split per-PCI logic from xenParsePCI() > > > I have pushed the first four patches. > >> xen_common: Split per-Vfi logic from xenParseVif() >> xen_common: convert to typesafe virConf acessors > Okay, I'll re-work these other 2 and submit a v3. > > >> xen_common: Fix a few memory leaks >> > > This one won't be necessary. > > Jano Thanks for the review! -- Fabiano Fidêncio -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
