Re: [PATCHv3 3/7] vmx: convert to typesafe virConf accessors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 28, 2018 at 12:28:22AM +0200, Fabiano Fidêncio wrote:
Signed-off-by: Fabiano Fidêncio <fabiano@xxxxxxxxxxxx>
---
src/vmx/vmx.c | 194 +++++++++++++++++++++-------------------------------------
1 file changed, 70 insertions(+), 124 deletions(-)

-    if (virUUIDParse(value->str, uuid) < 0) {
-        virReportError(VIR_ERR_INTERNAL_ERROR,
-                       _("Could not parse UUID from string '%s'"), value->str);
-        return -1;
-    }
+    ret = 0;

-    return 0;
+  cleanup:

'make syntax-check' complains about two spaces in front of a label.

I will fix that before pushing.

Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano

+    VIR_FREE(string);
+    return ret;
}


Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux