On Thu, Jun 07, 2018 at 11:09:41PM +0200, Ján Tomko wrote:
On Thu, Jun 07, 2018 at 11:04:48PM +0200, Martin Kletzander wrote:On Thu, Jun 07, 2018 at 09:31:50PM +0200, Ján Tomko wrote:The commit summary speaks of moving checks, but the commit actually relaxes them. I would not expect functional changes from that message. How about: qemu: relax and move SMM checks to validation phaseHere you suggest changing the commit message to describe both changes.On Thu, Jun 07, 2018 at 10:37:40AM +0200, Martin Kletzander wrote:We are still hoping all of such checks will be moved there and this is one small step in that direction. One of the things that this is improving is the fact that instead of error message *that was wrong) you get when starting a domain with SMM and i440fx we(that was wrong)allow the setting to go through. SMM option exists and makes sense on i440fx as well (basically whenever that _SMM_OPT capability is set). Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx> --- src/qemu/qemu_capabilities.c | 11 ----------- src/qemu/qemu_capabilities.h | 3 --- src/qemu/qemu_command.c | 12 ++---------- src/qemu/qemu_domain.c | 15 ++++++++++++--- 4 files changed, 14 insertions(+), 27 deletions(-)With the commit summary adjusted or changes split in two:
^^ DUH!!!
Here you are suggesting to split it into two. I'm fine with both, just tell me what you meant so I can fix it up, thanks.Summary adjusted OR changes split, IOW: don't leave functional changes in the commit named 'Move' Of course, the split is nicer.
Of course, will do that.
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
