On Tue, Sep 15, 2009 at 12:09:53PM +0200, Paolo Bonzini wrote: > On 09/15/2009 11:43 AM, Daniel P. Berrange wrote: > >I think we possibly ought to move<tftp> one level higher up, outside > >of the<ip> tag, since you can have a TFTP server regardless of whether > >we've configured IP/dhcp details, and in the future we may well have > >multiple<ip> tags. > > In principle, the ip@address attribute would be the address to which the > TFTP server would bind. So if you have multiple <ip> tags you would > also start multiple TFTP servers, each bound to a different address and > possibly with a different root. Ah yes, that is a good point. In that case ACK to your 3rd patch Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list