Re: [PATCH 5/8] qemu: implement vsock hotplug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 04, 2018 at 12:13:07PM -0400, John Ferlan wrote:


On 05/30/2018 10:57 AM, Ján Tomko wrote:
Allow hotplugging the vsock device.

https://bugzilla.redhat.com/show_bug.cgi?id=1291851

Signed-off-by: Ján Tomko <jtomko@xxxxxxxxxx>
---
 src/qemu/qemu_driver.c  |  9 ++++++-
 src/qemu/qemu_hotplug.c | 70 +++++++++++++++++++++++++++++++++++++++++++++++++
 src/qemu/qemu_hotplug.h |  4 +++
 3 files changed, 82 insertions(+), 1 deletion(-)


Why is QEMU_CAPS_DEVICE_VHOST_VSOCK never checked in the command line
startup code?  Was that forgotten or just felt not needed.


Oops, I forgot to add it.

I have sent a separate patch adding it to qemuDomainDeviceDefValidate,
so that both domain startup and (after this series) hotplug will
be able to catch the error.

Jano

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux