An upstream discussion resulted into an agreement that this can be finally deleted. https://www.redhat.com/archives/libvir-list/2018-June/msg00079.html This applies on top of my branch collecting all ACKed postings of recent blockdev-related work. Current version can be fetched by: git fetch git://pipo.sk/pipo/libvirt.git blockdev-staging Peter Krempa (10): tests: Drop tests enabling allowDiskFormatProbing qemu: conf: Remove 'allow_disk_format_probing' config option qemu: driver: Remove impossible code path in qemuDomainSnapshotCreateInactiveExternal security: Remove VIR_SECURITY_MANAGER_ALLOW_DISK_PROBE security: aa-helper: Remove the -p parameter tests: virstoragetest: Add complementary test case for QED format tests: storage: Absorb ALLOW_PROBE flag into the TEST_CHAIN macro tests: storage: Drop format probing from tests tests: storage: Drop duplicate tests with TEST_CHAIN util: storage: remove 'allow_probe' from virStorageFileGetMetadata src/qemu/qemu.conf | 12 --- src/qemu/qemu_conf.c | 8 +- src/qemu/qemu_conf.h | 1 - src/qemu/qemu_domain.c | 56 +++-------- src/qemu/qemu_driver.c | 26 +---- src/qemu/test_libvirtd_qemu.aug.in | 1 - src/security/security_apparmor.c | 6 +- src/security/security_manager.c | 7 -- src/security/security_manager.h | 5 +- src/security/virt-aa-helper.c | 15 +-- src/util/virstoragefile.c | 18 ++-- src/util/virstoragefile.h | 1 - .../qemuxml2argvdata/disk-many-format-probing.args | 32 ------ .../qemuxml2argvdata/disk-many-format-probing.xml | 48 --------- tests/qemuxml2argvtest.c | 6 -- .../disk-many-format-probing.xml | 52 ---------- tests/qemuxml2xmltest.c | 6 -- tests/virstoragetest.c | 109 ++++++--------------- 18 files changed, 70 insertions(+), 339 deletions(-) delete mode 100644 tests/qemuxml2argvdata/disk-many-format-probing.args delete mode 100644 tests/qemuxml2argvdata/disk-many-format-probing.xml delete mode 100644 tests/qemuxml2xmloutdata/disk-many-format-probing.xml -- 2.16.2 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list