On 05/31/2018 03:26 PM, Peter Krempa wrote: > In commit 8bebb2b735d I've refactored how the detach of disk with a > managed persistent reservations object is handled. After the commit if > any disk with a managed PR object would be removed libvirt would also > attempt to remove the shared 'pr-manager-helper' object potentially used > by other disks. > > Thankfully this should not have practical impact as qemu should reject > deletion of the object if it was still used and the rest of the code is > correct. > > Fix this by removing the disk from the definition earlier and checking > if the shared/managed pr-manager-helper object is still needed. > > This basically splits the detach code for the managed PR object from the > unmanaged ones. The same separation will follow for the attachment code > as well as it greatly simplifies -blockdev support for this. > > Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx> > --- > src/qemu/qemu_hotplug.c | 29 ++++++++++++++++++----------- > 1 file changed, 18 insertions(+), 11 deletions(-) ACK and SFF (safe for freeze). Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
