Re: [PATCH 1/3] virDomainDefParseXML: Free @tmp when parsing genid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 31, 2018 at 09:16:10 +0200, Michal Privoznik wrote:
> On 05/30/2018 06:46 PM, Peter Krempa wrote:
> > On Wed, May 30, 2018 at 18:04:27 +0200, Michal Privoznik wrote:

[...]

> >> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> >> index 27e2bd50eb..d8b4fbd6b0 100644
> >> --- a/src/conf/domain_conf.c
> >> +++ b/src/conf/domain_conf.c
> >> @@ -19120,6 +19120,7 @@ virDomainDefParseXML(xmlDocPtr xml,
> >>                                 "%s", _("malformed genid element"));
> >>                  goto error;
> >>              }
> >> +            VIR_FREE(tmp);
> > 
> > 
> > ACK
> > 
> 
> And safe for freeze? ;-) This one fixes a feature that was introduced in
> this release. The rest of the patches can go after the release.

Yes. I thought it was obvious :)

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux