[PATCH 00/10] Use better PRNG

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is inspired by bug reported here [1]. Even though Eric suggested
calling this Linux syscall when building without gnutls [2] I've decided
to not implement it. Firstly, we build with gnuls everywhere (even
Windows), secondly I see no appealing reason to special case Linux -
/dev/urandom is good for both Linux and FreeBSD.

Once these are merged I'm probably going to send patch set that makes
gnutls mandatory. I'm tired of all those WITH_GNUTLS if-defs (esp. in
function arguments). But that is orthogonal to what I'm solving here.

Also, I'm not quite sure this is a release material, so I'm fine with
merging this after the release.

1: https://www.redhat.com/archives/libvirt-users/2018-May/msg00097.html
2: https://www.redhat.com/archives/libvirt-users/2018-May/msg00100.html

Michal Privoznik (10):
  virRandomBytes: Fix return value
  virCryptoGenerateRandom: rename ret
  virCryptoGenerateRandom: Explain gnults error
  virCryptoGenerateRandom: Don't allocate return buffer
  virRandomBytes: Prefer saferead over plain read
  virRandomBytes: Report error
  virRandomBytes: Use gnutls_rnd whenever possible
  virrandom: Make virRandomBits better
  virUUIDGenerate don't fall back to virRandomBits
  vircrypto: Drop virCryptoGenerateRandom

 src/libvirt_private.syms |   1 -
 src/qemu/qemu_domain.c   |  13 ++++--
 src/util/vircrypto.c     |  41 -------------------
 src/util/vircrypto.h     |   2 -
 src/util/virrandom.c     | 103 ++++++++++++++++-------------------------------
 src/util/viruuid.c       |  25 ++----------
 tests/qemuxml2argvmock.c |  13 ------
 tests/vircryptotest.c    |   4 +-
 8 files changed, 48 insertions(+), 154 deletions(-)

-- 
2.16.1

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux