Re: [PATCHv2 3/3] xen_common: convert to typesafe virConf accessors

[Ján Tomko <jtomko@xxxxxxxxxx>]

On Sun, May 27, 2018 at 02:08:58PM +0200, Fabiano Fidêncio wrote:
> On Sun, May 27, 2018 at 1:17 PM, Ján Tomko <jtomko@xxxxxxxxxx> wrote:
> > On Sat, May 26, 2018 at 11:00:27PM +0200, Fabiano Fidêncio wrote:
> > > From: Fabiano Fidêncio <fidencio@xxxxxxxxxx>
> > >
> > > There are still some places using virConfGetValue() and then checking
> > > the specific type of the pointers and so on.
> > >
> > > Those place are not going to be changed as:
> > > - Directly using virConfGetValue*() would trigger virReportError() on
> > > their current code
> >
> >
> > Is that a problem in xenParseCPUFeatures?
>
> It would, at least, generate one more log, which would be misleading
> whoever ends up debugging some issue on that codepath later on.

I don't see it.
xenConfigGetULong already reports an error when the "maxvcpus" value is
malformed.

Jano

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list