Re: [PATCH v2 0/3] adding virGetLastErrorCode/Domain to paritally replace virGetLastError

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Patch looks good, many thanks Eric.

Ramy

On Wed, May 9, 2018 at 12:58 PM, Erik Skultety <eskultet@xxxxxxxxxx> wrote:
> On Sat, May 05, 2018 at 01:04:18PM +0100, ramyelkest wrote:
>> Changes from v1[1]:
>>
>> * removed virHasLastError() and s/virHasLastError/virGetLastErrorCode/g
>> * replaced in missed files: virmodule.c and virnetlibsshsession.c
>> * better split of patches
>>
>> [1] https://www.redhat.com/archives/libvir-list/2018-May/msg00259.html
>>
>> ramyelkest (3):
>>   util: cleanup: using virGetLastErrorMessage instead of err->message
>>   util: added virGetLastErrorCode/Domain
>>   all: replacing virGetLastError with virGetLastErrorCode where we can
>
> I suggested some minor adjustments to your patches without the need for a v3,
> so let me know if you agree and I'll merge the series.
>
> Erik

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux