Re: [PATCH 4/8] qemu: monitor: Drop QEMU_CHECK_MONITOR_JSON... macros

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 22, 2018 at 15:24:06 +0200, Ján Tomko wrote:
> On Tue, May 22, 2018 at 02:35:44PM +0200, Peter Krempa wrote:
> > Monitor is now JSON only. Drop the old cruft.
> > 
> 
> In theory, you should still be able to get a domain with a text monitor
> via qemu-attach.
> 
> In practice, attaching to such domains seems pointless - if we don't
> support starting them, touching their mointor might just break them.

I can leave the part of the macro that checks whether the monitor is
JSON still in. That way it will at least report sane errors.

> Maybe we should drop qemu-attach as well?

I hope so, but it should be probably done separately.

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux