On Sat, May 19, 2018 at 01:01:47PM +0200, Filip Alac wrote: > Add support for hda 'output' codec for ich6 and ich9 sound devices, > which allow us to disable line-in for guest. > > Fixes: > https://bugzilla.redhat.com/show_bug.cgi?id=1126641 > > v1: > https://www.redhat.com/archives/libvir-list/2018-May/msg01311.html > > v2: > - Split patch into series of patches Although I agree with John, that splitting the patch added readability and logical order since v1, you need to make sure that make check and make syntax-check pass after every single patch, so the split with the tests he originally suggested couldn't have worked sadly because of how our test suite works, see my responses to individual patches. Erik -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list