Re: [PATCH v2 12/21] nwfilter: convert IP address learning code to virNWFilterBindingDefPtr

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 05/15/2018 01:43 PM, Daniel P. Berrangé wrote:
> Use the virNWFilterBindingDefPTr struct in the IP address learning code
> directly.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> ---
>  src/nwfilter/nwfilter_gentech_driver.c |  7 +-
>  src/nwfilter/nwfilter_learnipaddr.c    | 98 +++++++-------------------
>  src/nwfilter/nwfilter_learnipaddr.h    |  7 +-
>  3 files changed, 31 insertions(+), 81 deletions(-)
> 

One minor #else comment that would cause a build problem...

Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx>

John

[...]

> diff --git a/src/nwfilter/nwfilter_learnipaddr.c b/src/nwfilter/nwfilter_learnipaddr.c
> index 5080b73004..2149b4af69 100644
> --- a/src/nwfilter/nwfilter_learnipaddr.c
> +++ b/src/nwfilter/nwfilter_learnipaddr.c

[...]

>   */
>  int
>  virNWFilterLearnIPAddress(virNWFilterTechDriverPtr techdriver,
> -                          const char *ifname,
> +                          virNWFilterBindingDefPtr binding,
>                            int ifindex,
> -                          const char *linkdev,
> -                          const virMacAddr *macaddr,
> -                          const char *filtername,
> -                          virHashTablePtr filterparams,
>                            virNWFilterDriverStatePtr driver,
>                            enum howDetect howDetect)

There's a HAVE_LIBPCAP #else to this that's going to cause a build
failure...

>  {
>      int rc;
>      virThread thread;
>      virNWFilterIPAddrLearnReqPtr req = NULL;
> -    virHashTablePtr ht = NULL;
>  

[...]

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux