On Wed, May 16, 2018 at 10:52:56AM -0400, John Ferlan wrote: > Using a QEMU 2.12 tagged tree build and full build, used: > > tests/qemucapsprobe /home/qemu/x86_64-softmmu/qemu-system-x86_64 > \ > tests/qemucapabilitiesdata/caps_2.12.0.x86_64.replies > > VIR_TEST_REGENERATE_OUTPUT=1 tests/qemucapabilitiestest > VIR_TEST_REGENERATE_OUTPUT=1 tests/domaincapstest > > Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx> > --- > Reposting : > > https://www.redhat.com/archives/libvir-list/2018-May/msg00738.html > > with recent updates through commit id fe8a0679 I need to finish the work on adding some exact steps or possible docker image to regenerate capabilities. I would create a rule that if someone is updating replies files they should check whether the CPU changes are only because of different host CPU or whether there is some actual change. In the first case they should not be part of the patch, it just pollutes the diff with unnecessary changes. Additional note related to the first paragraph, I don't thing that we need to include "xen" related things in replies since they are not used by QEMU driver. Pavel
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
