On Wed, 2018-05-16 at 12:34 +0200, Pavel Hrdina wrote: > On Wed, May 16, 2018 at 11:20:26AM +0200, Andrea Bolognani wrote: > > Given how tiny the packages involved are, though, I think the > > trade-off is worth it, especially in light of the stuff I > > mentioned in the comments to the previous patch. > > For me this is different issue than the previous patch. This actually > moves the dependency into project that doesn't require it out of project > that requires it. It's not like both will use it so it's safe and good > enough to have it in the parent project. > > The only benefit that I can see is to have only mingw-* packages as > dependency of mingw builds, which might look nice and neat in the > configuration file but IMHO it's wrong. If we move them, it would be > nice to mention, that these packages are required by mingw build only > and that would feel weird, like why they are not only in the mingw > projects? > > I would rather have it technically correct than having the configuration > files look nice :). As I said, it's a trade-off. But you clearly feel strongly on the topic, and I kinda don't, so I'll just drop this patch :) -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
