ping? Quite a few easy/small ones in here :-)... Tks, John On 05/08/2018 08:47 AM, John Ferlan wrote: > Essentially fallout and preparatory steps needed in order to alter > the code to allow using qemu-img for creation of qcow[2] encrypted > volume. The following series: > > https://www.redhat.com/archives/libvir-list/2018-April/msg01578.html > > is the impetus for these changes. What will follow once more testing > is done are the adjustments to be able to qemu-img create a qcow[2] > encrypted volume and changes to allow qemu-img convert to also work. > Currently create is broken for qcow[2] encryption and convert is > broken for both qcow[2] and luks encryption. > > Patches 1&2 could be combined, but since some like separated adjustments > like that, I kept them separate. > > John Ferlan (12): > storage_util: Some code cleanup > storage_util: Cleanup usage of target.encryption > storage_util: Remove unnecessary check > storage_util: Rename virQEMUBuildLuksOpts > storage_util: Generate the qcow secret earlier > storage_util: Move secretPath generation > storage_util: Remove luks distinction from secret path and alias > storage_util: Split backing_fmt set in storageBackendCreateQemuImgOpts > storage_util: Split preallocate set in storageBackendCreateQemuImgOpts > storage_util: Move @type into _virStorageBackendQemuImgInfo > storage_util: Introduce storageBackendCreateQemuImgSetInput > storage_util: Introduce storageBackendDoCreateQemuImg > > src/libvirt_private.syms | 2 +- > src/storage/storage_util.c | 252 +++++++++++++++++++++++++++------------------ > src/util/virqemu.c | 8 +- > src/util/virqemu.h | 6 +- > 4 files changed, 158 insertions(+), 110 deletions(-) > -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list