On Mon, May 14, 2018 at 04:44:15PM -0600, Jim Fehlig wrote: > libxlDoDomainSave() is used in both the save and managedsave code > paths but was unconditionally setting hasManagedSave to true on > success. As a result, undefine would fail after a non-managed > save/restore operation. E.g. > > virsh define; virsh start > virsh save; virsh restore > virsh shutdown > virsh undefine > error: Refusing to undefine while domain managed save image exists > > Modify libxlDoDomainSave() to take an additional parameter to > specify managed vs non-managed save, and change callers to use it. > > Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxx> > --- > src/libxl/libxl_driver.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
