On 05/14/2018 06:41 AM, Peter Krempa wrote: > Everything can be disabled by not using the parent element. There's no > need to store this explicitly. Additionally it does not add any value > since any configuration is dropped if enabled='no' is configured. > > Drop the attribute and adjust the code accordingly.t > > Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx> > --- > docs/formatdomain.html.in | 21 ++-- > docs/schemas/storagecommon.rng | 3 - > src/util/virstoragefile.c | 117 +++++++++------------ > src/util/virstoragefile.h | 1 - > .../disk-virtio-scsi-reservations.xml | 4 +- > 5 files changed, 59 insertions(+), 87 deletions(-) > Hmm... I recall stating the same thing during v1 and v2 review, but got a deafening the design of XML was agreed upon already... John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
