On 05/14/2018 12:45 PM, Peter Krempa wrote: > Rather than always re-generating the alias store it in the definition > and in the status XML. > > Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx> > --- > src/qemu/qemu_command.c | 23 +++------------------ > src/qemu/qemu_command.h | 3 +-- > src/qemu/qemu_domain.c | 16 +++++++++++++-- > src/qemu/qemu_hotplug.c | 34 ++++++++++--------------------- > src/util/virstoragefile.c | 1 + > src/util/virstoragefile.h | 3 +++ > tests/qemustatusxml2xmldata/modern-in.xml | 4 ++++ > 7 files changed, 37 insertions(+), 47 deletions(-) Yes, this makes sense to me. I've kept alias in status XML for all the versions until the very last one. You have my ACK, but since John was opposed maybe we should ask for his opinion too (so that we don't go behind his back). Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list