On Thu, May 10, 2018 at 07:25:53PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou <kkoukiou@xxxxxxxxxx> > --- > data/org.libvirt.Connect.xml | 7 +++++++ > src/connect.c | 31 +++++++++++++++++++++++++++++++ > tests/test_connect.py | 33 +++++++++++++++++++++++++++++++++ > 3 files changed, 71 insertions(+) [...] > diff --git a/tests/test_connect.py b/tests/test_connect.py > index 8104a30..6e28b81 100755 > --- a/tests/test_connect.py > +++ b/tests/test_connect.py > @@ -30,6 +30,24 @@ class TestConnect(libvirttest.BaseTestClass): > </network> > ''' > > + minimal_storage_pool_xml = ''' > + <pool type='dir'> > + <name>foo</name> > + <uuid>35bb2ad9-388a-cdfe-461a-b8907f6e53fe</uuid> > + <capacity>107374182400</capacity> > + <allocation>0</allocation> > + <available>107374182400</available> capacity, allocation and available are not valid for storage pool creation. > + <target> > + <path>/foo</path> > + <permissions> > + <mode>0700</mode> > + <owner>10736</owner> > + <group>10736</group> > + </permissions> Since this supposed to be minimal XML I would remove permissions. > + </target> > + </pool> > + ''' > + Reviewed-by: Pavel Hrdina <phrdina@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list