Re: [dbus PATCH 05/19] Implement Build method for StoragePool Interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 07, 2018 at 04:40:46PM +0200, Katerina Koukiou wrote:
> VIR_STORAGE_POOL_EVENT_CREATED event was added in 3.1.
> Test should be fixed later on to use signal handler.
> 
> Signed-off-by: Katerina Koukiou <kkoukiou@xxxxxxxxxx>
> ---
>  data/org.libvirt.StoragePool.xml |  5 +++++
>  src/storagepool.c                | 25 +++++++++++++++++++++++++
>  tests/libvirttest.py             |  8 ++++++++
>  tests/test_storage.py            |  8 +++++++-
>  4 files changed, 45 insertions(+), 1 deletion(-)

[...]

> diff --git a/tests/test_storage.py b/tests/test_storage.py
> index 8c5d75f..cf13024 100755
> --- a/tests/test_storage.py
> +++ b/tests/test_storage.py
> @@ -4,6 +4,13 @@ import dbus
>  import libvirttest
>  
>  class TestStoragePool(libvirttest.BaseTestClass):
> +    def test_storage_pool_build(self):
> +        _, test_storage_pool = self.test_storage_pool()
> +        interface_obj = dbus.Interface(test_storage_pool,
> +                                       'org.libvirt.StoragePool')
> +        interface_obj.Destroy()
> +        interface_obj.Build(libvirttest.StoragePoolBuildFlags.NEW)
> +
>      def test_storage_pool_destroy(self):
>          def storage_pool_destroyed(path, event, _detail):
>              if event != libvirttest.StoragePoolEvent.STOPPED:
> @@ -13,7 +20,6 @@ class TestStoragePool(libvirttest.BaseTestClass):
>  
>          self.connect.connect_to_signal('StoragePoolEvent',
>                                         storage_pool_destroyed)
> -

Unrelated line removal.

Pavel

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux