On Wed, 2018-05-09 at 12:39 +0100, Daniel P. Berrangé wrote: > On Wed, May 09, 2018 at 01:34:53PM +0200, Andrea Bolognani wrote: > > 3) change libosinfo's autogen.sh not to mandate gtk-doc for all > > builds. > > > > Option 3) looks like the best one to me, mostly because I think > > the default behavior of checking for gtk-doc's presence and decide > > whether to build the API reference based on that is more sane than > > forcing gtk-doc to be present; moreover, --enable-gtk-doc is > > already in $DISTCHECK_CONFIGURE_FLAGS and prepare-release.sh, so > > there's no risk of accidentally generating a release that doesn't > > contain the API reference. > > Agreed - I looked back in history and it seems I added --enable-gtk-doc > to autogen.sh right at start when integrating gtk-doc. There's no good > reason given, and other projects work without this so lets remove it. Cool, I'll post a patch then. With the libxslt entries squashed in, and after the patch getting rid of --enable-gtk-doc has been merged into libosinfo, Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx> -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
