On Fri, Sep 04, 2009 at 07:16:26PM +0200, Jim Meyering wrote:
>
>
> >From 66133e3b9d80e9fadefd810786b0ff2f5c8e6875 Mon Sep 17 00:00:00 2001
> From: Jim Meyering <meyering@xxxxxxxxxx>
> Date: Fri, 4 Sep 2009 19:15:51 +0200
> Subject: [PATCH] network_conf.c: remove dead store to "err"
>
> * src/network_conf.c (virNetworkDefParseXML): ...and its decl.
> ---
> src/network_conf.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/src/network_conf.c b/src/network_conf.c
> index 58a4f32..3764bb4 100644
> --- a/src/network_conf.c
> +++ b/src/network_conf.c
> @@ -1,7 +1,7 @@
> /*
> * network_conf.c: network XML handling
> *
> - * Copyright (C) 2006-2008 Red Hat, Inc.
> + * Copyright (C) 2006-2009 Red Hat, Inc.
> * Copyright (C) 2006-2008 Daniel P. Berrange
> *
> * This library is free software; you can redistribute it and/or
> @@ -329,8 +329,7 @@ virNetworkDefParseXML(virConnectPtr conn,
> /* Extract network uuid */
> tmp = virXPathString(conn, "string(./uuid[1])", ctxt);
> if (!tmp) {
> - int err;
> - if ((err = virUUIDGenerate(def->uuid))) {
> + if (virUUIDGenerate(def->uuid)) {
> virNetworkReportError(conn, VIR_ERR_INTERNAL_ERROR,
> "%s", _("Failed to generate UUID"));
> goto error;
ACK, thanks Jim !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list