Changes from [v2]: * introduce a wrapper around canonicalize_file_name() instead of moving to realpath(); * fix more usages of mode_t with va_arg(). Changes from [v1]: * drop the virnetsockettest changes, since the relationship between the errors seen on FreeBSD and IPv4 clients connecting to IPv6 sockets has turned out to be just a red herring; * fix the mocking instead of dropping test cases that don't work without it. [v2] https://www.redhat.com/archives/libvir-list/2018-April/msg02685.html [v1] https://www.redhat.com/archives/libvir-list/2018-April/msg02611.html Andrea Bolognani (9): util: Introduce virFileCanonicalizePath() tests: Mock virFileCanonicalizePath() all: Use virFileCanonicalizePath() instead of canonicalize_file_name() tests: Stop mocking canonicalize_file_name() syntax-check: Prohibit canonicalize_file_name() tests: Fix mode_t usage with va_arg() tests: Build virpcimock on non-Linux tests: Extend NUMA mocking tests: Drop DO_TEST_LINUX() cfg.mk | 10 ++++ src/libvirt_private.syms | 1 + src/storage/storage_backend_fs.c | 2 +- src/util/virfile.c | 15 +++++- src/util/virfile.h | 1 + src/util/virpci.c | 2 +- tests/nssmock.c | 2 +- tests/qemuxml2argvmock.c | 38 ++++++++++---- tests/qemuxml2argvtest.c | 46 ++++++----------- tests/vircgroupmock.c | 2 +- tests/virpcimock.c | 104 ++++++++++++++++++++++----------------- tests/virstoragetest.c | 10 ++-- tests/virtestmock.c | 8 +-- 13 files changed, 141 insertions(+), 100 deletions(-) -- 2.14.3 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
