Re: [PATCH 31/35] tests: qemublock: basic qcow2 tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 04/25/2018 11:15 AM, Peter Krempa wrote:
> Add tests for backing chain handling, including a very long chain which
> is fully specified in the XML and an unterminated chain.
> 
> The top level disk image would generate the following '-drive':
> 
> file-qcow2-backing-chain-encryption.xml:
> -drive file=/var/lib/libvirt/images/a,encrypt.format=luks,
>     encrypt.key-secret=node-b-f-encalias,format=qcow2,if=none,id=drive-dummy
> -device virtio-blk-pci,scsi=off,drive=drive-dummy,id=dummy
> 
> file-qcow2-backing-chain-noopts.xml:
> -drive file=/var/lib/libvirt/images/rhel7.3.1507297895,format=qcow2,if=none,id=drive-dummy
> -device virtio-blk-pci,scsi=off,drive=drive-dummy,id=dummy
> 
> file-qcow2-backing-chain-unterminated.xml:
> -drive file=/var/lib/libvirt/images/rhel7.3.1507297895,format=qcow2,if=none,id=drive-dummy
> -device virtio-blk-pci,scsi=off,drive=drive-dummy,id=dummy
> 
> Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> ---
>  tests/qemublocktest.c                              |   3 +
>  .../file-qcow2-backing-chain-encryption.json       |  34 ++++++
>  .../file-qcow2-backing-chain-encryption.xml        |  31 +++++
>  .../xml2json/file-qcow2-backing-chain-noopts.json  | 130 +++++++++++++++++++++
>  .../xml2json/file-qcow2-backing-chain-noopts.xml   | 113 ++++++++++++++++++
>  .../file-qcow2-backing-chain-unterminated.json     |  25 ++++
>  .../file-qcow2-backing-chain-unterminated.xml      |  24 ++++
>  7 files changed, 360 insertions(+)
>  create mode 100644 tests/qemublocktestdata/xml2json/file-qcow2-backing-chain-encryption.json
>  create mode 100644 tests/qemublocktestdata/xml2json/file-qcow2-backing-chain-encryption.xml
>  create mode 100644 tests/qemublocktestdata/xml2json/file-qcow2-backing-chain-noopts.json
>  create mode 100644 tests/qemublocktestdata/xml2json/file-qcow2-backing-chain-noopts.xml
>  create mode 100644 tests/qemublocktestdata/xml2json/file-qcow2-backing-chain-unterminated.json
>  create mode 100644 tests/qemublocktestdata/xml2json/file-qcow2-backing-chain-unterminated.xml
> 

hahahaha... basic... hahahaha

and perhaps a more real-life example from -noopts output "#blockNNN"...
Too bad one of those rhel7.3 paths didn't have 3.14159265359 ...

Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx>

John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux