Re: [PATCH 25/35] tests: qemublock: Add basic 'raw' file test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 04/25/2018 11:15 AM, Peter Krempa wrote:
> Test the JSON props generator with a very simple 'raw' image with no
> other options. The node-names for the image are 31 bytes long so that we
> validate our node name detector.
> 
> The top level disk image would generate the following '-drive' cmdline:
> 
> -drive file=/var/lib/libvirt/images/i.img,format=raw,if=none,id=drive-dummy
> -device virtio-blk-pci,scsi=off,drive=drive-dummy,id=dummy

One would think we'd be able to test that too ;-)

> 
> Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> ---
>  tests/qemublocktest.c                                 |  2 ++
>  tests/qemublocktestdata/xml2json/file-raw-noopts.json | 12 ++++++++++++
>  tests/qemublocktestdata/xml2json/file-raw-noopts.xml  | 12 ++++++++++++
>  3 files changed, 26 insertions(+)
>  create mode 100644 tests/qemublocktestdata/xml2json/file-raw-noopts.json
>  create mode 100644 tests/qemublocktestdata/xml2json/file-raw-noopts.xml
> 

Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx>

John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux