On 04/25/2018 11:15 AM, Peter Krempa wrote: > Handle VIR_STORAGE_TYPE_DIR in qemuBlockStorageSourceGetBackendProps so > that a 'vvfat' driver is used, which emulates a FAT filesystem > containing the folders. > > qemu requires us to add it as a storage layer, since a 'raw' layer is > usually put on top of it. > > Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx> > --- > src/qemu/qemu_block.c | 27 ++++++++++++++++++++++++++- > 1 file changed, 26 insertions(+), 1 deletion(-) > So I suppose the only question I have for this one relates to whether vvfat is supported in QEMU 1.5 or later and that's been the expectation to use it for a long time, but libvirt wasn't doing the right thing? Assuming 1.5 or later and that we don't have to do anything special or use qemuBlockStorageSourceGetFileProps for some variant between 1.5 and when vvfat was first supported, Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx> John I'm half surprised we didn't have some test failure! -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
