Re: [PATCH 01/35] storage: Properly track that backing chain members are readonly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 04/25/2018 11:15 AM, Peter Krempa wrote:
> Everything besides the top of the chain is readonly. Track this when
> parsing the XML and detecting the chain from the disk. Also fix the
> state when taking snapshots.
> 
> All other cases where the top image is changed already preserve the
> readonly state from the original image.
> 
> Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> ---
>  src/conf/domain_conf.c    | 3 +++
>  src/qemu/qemu_driver.c    | 3 +++
>  src/util/virstoragefile.c | 1 +
>  3 files changed, 7 insertions(+)
> 

Any concerns with virDomainDiskDefCheckABIStability?  Since true would
now be the default - is it possible a save file comparison causes issues?

Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx>

John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux