Dismiss this packages guys. I forgot --cover-letter, since I was submitting only one single patch to fix this problem. Sending a V5 soon. -- Julio Cesar Faracco 2018-05-01 12:47 GMT-03:00 Julio Faracco <jcfaracco@xxxxxxxxx>: > The 'domrename' command needs to check if the new domain name contains > the slash character. This character is not accepted by libvirt XML > definition because it is an invalid char (see Cole's commit b1fc6a7b7). > This commit enhace the 'domrename' command adding this check. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1333232 > > Signed-off-by: Julio Faracco <jcfaracco@xxxxxxxxx> > --- > src/qemu/qemu_driver.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > index 7484b00e23..79a1ddcebf 100644 > --- a/src/qemu/qemu_driver.c > +++ b/src/qemu/qemu_driver.c > @@ -20752,6 +20752,12 @@ qemuDomainRenameCallback(virDomainObjPtr vm, > > virCheckFlags(0, ret); > > + if (strchr(new_name, '/')) { > + virReportError(VIR_ERR_XML_ERROR, > + _("name %s cannot contain '/'"), new_name); > + return -1; > + } > + > cfg = virQEMUDriverGetConfig(driver); > > if (VIR_STRDUP(new_dom_name, new_name) < 0) > -- > 2.17.0 > -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
