Re: [PATCH 2/3] conf: Add a comment warning about boolean feature XML

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 04/17/2018 02:40 PM, Cole Robinson wrote:
> This is the old style and we really shouldn't be adding any more
> examples like this. Add a comment to warn devs away
> 
> Signed-off-by: Cole Robinson <crobinso@xxxxxxxxxx>
> ---
>  docs/schemas/domaincommon.rng | 6 +++++-
>  src/conf/domain_conf.c        | 2 ++
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 

The domaincommon.rng change should go in patch 1.

I'll leave it up to you whether to combine the domain_conf.c change as well.

Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx>

John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux