On Thu, Apr 26, 2018 at 05:07 PM +0200, John Ferlan <jferlan@xxxxxxxxxx> wrote: > On 04/12/2018 08:40 AM, Marc Hartmayer wrote: >> As a result, you can later determine at the callback which program has > > s/at/during > s/has to be/was > >> to be used. This makes it easier to refactor the code in the future >> and is less prone to error. >> >> Signed-off-by: Marc Hartmayer <mhartmay@xxxxxxxxxxxxxxxxxx> >> Reviewed-by: Boris Fiuczynski <fiuczy@xxxxxxxxxxxxxxxxxx> >> --- >> src/remote/remote_daemon_dispatch.c | 108 ++++++++++++++++++++---------------- >> 1 file changed, 59 insertions(+), 49 deletions(-) >> > > The $SUBJ is a bit long... > > How about just: > > remote: Save reference to program in daemonClientEventCallback Yep, that’s better. > > > > Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx> Thanks. > > John > -- Beste Grüße / Kind regards Marc Hartmayer IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
