On Fri, Sep 04, 2009 at 05:27:58PM +0200, Jim Meyering wrote:
> Another dead store:
>
> >From 06c5ed162cbdcfec74461e9d09c82244242cc6a2 Mon Sep 17 00:00:00 2001
> From: Jim Meyering <meyering@xxxxxxxxxx>
> Date: Fri, 4 Sep 2009 17:27:34 +0200
> Subject: [PATCH] domain_conf.c: remove dead store
>
> * src/domain_conf.c (virDomainSaveXML): ...and decl of "err".
> ---
> src/domain_conf.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/src/domain_conf.c b/src/domain_conf.c
> index 8dde5dd..4e8ad37 100644
> --- a/src/domain_conf.c
> +++ b/src/domain_conf.c
> @@ -4456,12 +4456,11 @@ int virDomainSaveXML(virConnectPtr conn,
> char *configFile = NULL;
> int fd = -1, ret = -1;
> size_t towrite;
> - int err;
>
> if ((configFile = virDomainConfigFile(conn, configDir, def->name)) == NULL)
> goto cleanup;
>
> - if ((err = virFileMakePath(configDir))) {
> + if (virFileMakePath(configDir)) {
> virReportSystemError(conn, errno,
> _("cannot create config directory '%s'"),
> configDir);
Okay, that one is obvious, ACK
thanks !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list