On Thu, Sep 03, 2009 at 06:45:54PM +0200, Matthias Bolte wrote:
> * src/esx/esx_driver.c: add esxDomainUndefine() based on
> esxVI_UnregisterVM()
> * src/esx/esx_vi_methods.[ch]: add esxVI_UnregisterVM()
Looks fine, there is just that small limitiation
+ if (powerState != esxVI_VirtualMachinePowerState_Suspended &&
+ powerState != esxVI_VirtualMachinePowerState_PoweredOff) {
+ ESX_ERROR(domain->conn, VIR_ERR_OPERATION_INVALID,
+ "Domain is not suspended or powered off");
+ goto failure;
I don't think we have that restriction of non-running domain
in other drivers, but I think it's fine to error then, just a driver
specific behaviour.
Patch looks just fine, applied,
thanks !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list