On Wed, Apr 25, 2018 at 02:58:12PM +0200, Katerina Koukiou wrote:
On Wed, 2018-04-25 at 13:43 +0200, Ján Tomko wrote:On Wed, Apr 25, 2018 at 12:20:18PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou <kkoukiou@xxxxxxxxxx> > --- > data/org.libvirt.Domain.xml | 7 +++++++ > src/domain.c | 40 > ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 47 insertions(+) > > diff --git a/data/org.libvirt.Domain.xml > b/data/org.libvirt.Domain.xml > index 2d8f6fe..6f80cc7 100644 > --- a/data/org.libvirt.Domain.xml > +++ b/data/org.libvirt.Domain.xml > @@ -171,6 +171,13 @@ > <arg name="flags" type="u" direction="in"/> > <arg name="BlkioParameters" type="a{sv}" direction="out"/> > </method> > + <method name="GetBlockIoTune"> s/Io/IO/ it's capitalized in every API implemented so far'I follow the convention that I keep the method name as the original API name, apart from when there is the `Flags` suffix. Would you mind if we keep using this approach?
Yes, I would mind. But the explanation makes sense. With or without the name change: Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx> Jano
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
