Re: [dbus PATCH 08/15] Implement GetHostname method for Domain Interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 25, 2018 at 01:22:40PM +0200, Peter Krempa wrote:
On Wed, Apr 25, 2018 at 13:15:06 +0200, Ján Tomko wrote:
On Wed, Apr 25, 2018 at 12:20:23PM +0200, Katerina Koukiou wrote:
> Signed-off-by: Katerina Koukiou <kkoukiou@xxxxxxxxxx>
> ---
> data/org.libvirt.Domain.xml |  6 ++++++
> src/domain.c                | 28 ++++++++++++++++++++++++++++
> 2 files changed, 34 insertions(+)
>
> diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml
> index 343fc08..1324db8 100644
> --- a/data/org.libvirt.Domain.xml
> +++ b/data/org.libvirt.Domain.xml
> @@ -209,6 +209,12 @@
>       <arg name="flags" type="u" direction="in"/>
>       <arg name="vcpus" type="a{sv}" direction="out"/>
>     </method>
> +    <method name="GetHostname">
> +      <annotation name="org.gtk.GDBus.DocString"
> +        value="See https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetHostname"/>
> +      <arg name="flags" type="u" direction="in"/>
> +      <arg name="hostname" type="s" direction="out"/>
> +    </method>
>     <method name="GetJobInfo">
>       <annotation name="org.gtk.GDBus.DocString"
>         value="See https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetJobInfo"/>

The code looks good to me, but the API is only supported by the openvz
driver: https://libvirt.org/hvsupport.html
Is it worth exposing?

It might:
https://bugzilla.redhat.com/show_bug.cgi?id=1515831
 [RFE] Add API to access guest-get-hostname from QEMU-GA

Okay then:

Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux