On 04/23/2018 10:16 AM, Martin Kletzander wrote: > On Mon, Apr 23, 2018 at 02:25:26PM +0100, Daniel P. Berrangé wrote: >> Personally I'm not a fan of adding the extra space - the cast is >> associated >> with the variable, so I don't think it needs it. >> > > I know we've discussed it earlier, and I don't want to repeat myself, > but for > the sake of keeping it in the conversation; there are spaces around > everything > except function calls, but in the end it's just a clearer separation. > I used to > prefer non-spaced casts too, but then I misread some and realized it's > similar > to arithmetics for example. > > And before anyone starts shouting at me that it is very subjective and > it all > depeds on x, y, and z, including your terminal font, I agree, it for > sure is. > And I also agree that we should not be spending almost any of out time > with > something that's very close to bikeshedding =) I just want this to be > unified > across the codebase, and if the consensus is that there should be no > spaces, > then I'll resend the series with the spaces removed. > > Just let me know so that I don't send ton of patches for no reason. I would also vote for no spaces - I've always seen "lack of a space after a single word in parens" as the "this is a typecast" operator (it makes sense in my addled brain). -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
