On Tue, Apr 24, 2018 at 02:16:59PM +0200, Michal Privoznik wrote: > On 04/19/2018 07:09 PM, Daniel P. Berrangé wrote: > > The Xen driver was recently deleted, but libvirtd has left over code > > that tries to use it. Fortunately this is dead code because WITH_XEN > > will never be defined anymore. > > > > Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> > > --- > > src/remote/remote_daemon.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/src/remote/remote_daemon.c b/src/remote/remote_daemon.c > > index 31c6ce1b61..3e02297eee 100644 > > --- a/src/remote/remote_daemon.c > > +++ b/src/remote/remote_daemon.c > > @@ -328,9 +328,6 @@ static void daemonInitialize(void) > > #ifdef WITH_NWFILTER > > VIR_DAEMON_LOAD_MODULE(nwfilterRegister, "nwfilter"); > > #endif > > -#ifdef WITH_XEN > > - VIR_DAEMON_LOAD_MODULE(xenRegister, "xen"); > > -#endif > > #ifdef WITH_LIBXL > > VIR_DAEMON_LOAD_MODULE(libxlRegister, "libxl"); > > #endif > > > > ACK please. Also might be worth removing the following from virsh (in a > separate patch perhaps?) Yes, I'll push that as a trivial patch too > > diff --git i/tools/virsh.c w/tools/virsh.c > index 5f8352e861..62226eea4c 100644 > --- i/tools/virsh.c > +++ w/tools/virsh.c > @@ -526,9 +526,6 @@ virshShowVersion(vshControl *ctl ATTRIBUTE_UNUSED) > #ifdef WITH_UML > vshPrint(ctl, " UML"); > #endif > -#ifdef WITH_XEN > - vshPrint(ctl, " Xen"); > -#endif > #ifdef WITH_LIBXL > vshPrint(ctl, " LibXL"); > #endif > > Michal Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
