Re: [PATCH v2 05/11] conf: Add flag to regenerate genid for virDomainDefCopy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 23, 2018 at 19:59:59 -0400, John Ferlan wrote:
> Add the VIR_DOMAIN_DEF_COPY_NEWGENID to indicate that the generated
> domain definition should adjust the genid value before returning the
> @def to the caller.
> 
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> ---
>  src/conf/domain_conf.c | 12 ++++++++++++
>  src/conf/domain_conf.h |  5 +++++
>  src/qemu/qemu_driver.c |  3 ++-
>  src/test/test_driver.c |  3 ++-
>  4 files changed, 21 insertions(+), 2 deletions(-)

IMO all this code should not be necessary. Code paths which knowingly
need to change the GENID should do so explicitly rather than pulling the
logic here.

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux