On Mon, Apr 02, 2018 at 09:16:40AM -0400, John Ferlan wrote: > For vmwareDomObjFromDomainLocked and vmwareDomainLookupByID > let's return a locked and referenced @vm object so that callers > can then use the common and more consistent virDomainObjEndAPI > in order to handle cleanup rather than needing to know that the > returned object is locked and calling virObjectUnlock. > > The LookupByName already returns the ref counted and locked object, > so this will make things more consistent. > > For vmwareDomainUndefineFlags and vmwareDomainShutdownFlags since > virDomainObjListRemove will return an unlocked object, we need to > relock before making the EndAPI call. > > Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx> > --- > src/vmware/vmware_driver.c | 53 +++++++++++++++++----------------------------- > 1 file changed, 19 insertions(+), 34 deletions(-) Reviewed-by: Pavel Hrdina <phrdina@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
