On Thu, Apr 19, 2018 at 05:03:37PM +0200, Ján Tomko wrote:
> On Thu, Apr 19, 2018 at 03:35:33PM +0100, Daniel P. Berrangé wrote:
> > The libvirt python module is supposed to build with historical versions
> > of the API back to 0.9.1, which means all constants / methods must be
The incomplete sentance here is supposed to continue with
wrapped in conditionals. This was accidentally forgotten in:
who knows how I lost that after first entering it...
> >
> > commit 314b2346df2d8e2d7d705b003c693b4fa0189bdf
> > Author: Edgar Kaziakhmedov <edgar.kaziakhmedov@xxxxxxxxxxxxx>
> > Date: Wed Feb 7 17:49:30 2018 +0300
> >
> > Set hints for virPyDictToTypedParams
> >
> > Predefine hints for all parameters possible to avoid wrong type
> > convert.
> >
> > This broke the build against any libvirt < 2.0.0
> >
> > Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> > ---
> > libvirt-override.c | 32 ++++++++++++++++++++++++++++++++
> > 1 file changed, 32 insertions(+)
> >
>
> Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>
>
> Jano
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
