On Thu, Apr 19, 2018 at 16:37:23 +0200, Andrea Bolognani wrote: > On Thu, 2018-04-19 at 16:15 +0200, Peter Krempa wrote: > > On Thu, Apr 19, 2018 at 15:45:52 +0200, Andrea Bolognani wrote: > > > Mh, that's trickier than I initially though, because > > > virBitmapParseSeparator() calls virReportError() itself on parse > > > failure, and changing doesn't sound feasible. > > > > I think logging of the error is okay, we just probably should reset it. > > > > At any rate this patch can be pushed as-is ... well after it passes > > build checks ;) > > Are you referring to the syntax-check failure? I posted a v2 that > fixes that, but also changes 1/2, without which 2/2 can't work. No, I was referring to making that whole function pass even when the numad hints can't be parsed. I'll do a review of v2 in a bit.
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
