[libvirt] Dead code vs. XXX comment: remove or not?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



clang reported that this assignment to type is a dead store,
since type is never used after this point.

This is xm_internal.c, line 1074:

            /* XXX Forcing to pretend its a bridge */
            if (type == -1) {
                type = 1;
            }

Normally I'd just remove the whole if block, but the XXX comment
makes me think someone has plans for this code.

I'll wait for a second opinion.

--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]